release-24.1: pkg/ui: properly derive XScale in statement details page #121461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #121366.
/cc @cockroachdb/release
Fixes: #121362
Epic: none
#118680 introduced code to align the timeseries charts on the statement details page to the time range set by the time picker, instead of the time range that we had available data for.
The code contained a bug where it would set the start & end of the XScale to
Moment.prototype.valueOf
instead of the result of callingMoment.prototype.valueOf()
. This causes the start & end timestamps to be set to functions, instead of unix timestamps, which broke the charts.This PR simply invokes the function.
Release note (bug fix): The timeseries graphs shown on the SQL Activity statement details page in DB Console will now render properly, after fixing a bug related to setting the time range of the charts.
Release justification: fix for a UI bug found in the SQL Activity statement details page.