Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: pkg/ui: properly derive XScale in statement details page #121461

Merged

Conversation

abarganier
Copy link
Member

Backport 1/1 commits from #121366.

/cc @cockroachdb/release


Fixes: #121362

Epic: none

#118680 introduced code to align the timeseries charts on the statement details page to the time range set by the time picker, instead of the time range that we had available data for.

The code contained a bug where it would set the start & end of the XScale to Moment.prototype.valueOf instead of the result of calling Moment.prototype.valueOf(). This causes the start & end timestamps to be set to functions, instead of unix timestamps, which broke the charts.

This PR simply invokes the function.

Release note (bug fix): The timeseries graphs shown on the SQL Activity statement details page in DB Console will now render properly, after fixing a bug related to setting the time range of the charts.


Release justification: fix for a UI bug found in the SQL Activity statement details page.

Fixes: cockroachdb#121362

cockroachdb#118680 introduced code to
align the timeseries charts on the statement details page to the time
range set by the time picker, instead of the time range that we had
available data for.

The code contained a bug where it would set the start & end of the
XScale to `Moment.prototype.valueOf` instead of the result of *calling*
`Moment.prototype.valueOf()`. This causes the start & end timestamps to
be set to functions, instead of unix timestamps, which broke the charts.

This PR simply invokes the function.

Release note (bug fix): The timeseries graphs shown on the SQL Activity
statement details page in DB Console will now render properly, after
fixing a bug related to setting the time range of the charts.
Copy link

blathers-crl bot commented Apr 1, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@abarganier abarganier marked this pull request as ready for review April 1, 2024 15:02
@abarganier abarganier requested a review from a team as a code owner April 1, 2024 15:02
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 1, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian
Copy link
Collaborator

Confirmed with @abarganier that this fix was manually verified.

@abarganier
Copy link
Member Author

TFTRs!

@abarganier abarganier merged commit 7f3782a into cockroachdb:release-24.1 Apr 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants