Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: optbuilder: subject SELECT FOR UPDATE to sql_safe_updates #121466

Merged
merged 1 commit into from Apr 3, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 1, 2024

Backport 1/1 commits from #121403 on behalf of @michae2.

/cc @cockroachdb/release


Fixes: #110131

Release note (sql change): With sql_safe_updates set to true, SELECT FOR UPDATE and SELECT FOR SHARE statements now return an error if they do not contain either a WHERE clause or LIMIT clause.

Also, UPDATE and DELETE statements without WHERE clauses but with LIMIT clauses now bypass sql_safe_updates, which better matches MySQL behavior.


Release justification: add a guardrail to prevent a dangerous operation now that RC is GA.

@blathers-crl blathers-crl bot requested a review from a team as a code owner April 1, 2024 16:53
@blathers-crl blathers-crl bot requested review from rytaft and removed request for a team April 1, 2024 16:53
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 1, 2024
Copy link
Author

blathers-crl bot commented Apr 1, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 1, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-121403 branch from 6562fea to 7843df5 Compare April 1, 2024 16:53
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2)

@michae2 michae2 force-pushed the blathers/backport-release-24.1-121403 branch from 7843df5 to 2e8b336 Compare April 1, 2024 22:16
Fixes: #110131

Release note (sql change): With sql_safe_updates set to true, SELECT FOR UPDATE and
SELECT FOR SHARE statements now return an error if they do not contain
either a WHERE clause or LIMIT clause.

Also, UPDATE and DELETE statements without WHERE clauses but with LIMIT
clauses now bypass sql_safe_updates, which better matches MySQL
behavior.
@michae2 michae2 force-pushed the blathers/backport-release-24.1-121403 branch from 2e8b336 to 0278ec4 Compare April 3, 2024 01:07
@michae2 michae2 mentioned this pull request Apr 3, 2024
@michae2 michae2 merged commit 4a623b2 into release-24.1 Apr 3, 2024
5 of 6 checks passed
@michae2 michae2 deleted the blathers/backport-release-24.1-121403 branch April 3, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants