Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: skip TestRestorePauseOnError #121484

Merged
merged 1 commit into from
Apr 1, 2024
Merged

backupccl: skip TestRestorePauseOnError #121484

merged 1 commit into from
Apr 1, 2024

Conversation

rickystewart
Copy link
Collaborator

Flaky. See #121342

Epic: None
Release note: None

@rickystewart
backupccl: skip TestRestorePauseOnError
cfd7267 
Flaky. See cockroachdb#121342

Epic: None
Release note: None
@rickystewart rickystewart requested a review from a team as a code owner April 1, 2024 19:53
@rickystewart rickystewart requested review from stevendanna and removed request for a team April 1, 2024 19:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart requested a review from rail April 1, 2024 19:59
@rickystewart
Copy link
Collaborator Author

bors r=rail

@craig
Copy link
Contributor

craig bot commented Apr 1, 2024

Build succeeded:

@craig craig bot merged commit c43f54c into cockroachdb:master Apr 1, 2024
21 of 22 checks passed
rickystewart added a commit to rickystewart/cockroach that referenced this pull request Apr 4, 2024
@rickystewart
backupccl: remove unnecessary call to skip.WithIssue()
1aeedad 
There are two here from two PR's that skipped the same test at around
the same time (cockroachdb#121484 and cockroachdb#121494)

Epic: none
Release note: None
@rickystewart rickystewart mentioned this pull request Apr 4, 2024
Merged
craig bot pushed a commit that referenced this pull request Apr 4, 2024
@rickystewart
Merge #121799
fdaf7bd 
121799: backupccl: remove unnecessary call to `skip.WithIssue()` r=msbutler a=rickystewart

There are two here from two PR's that skipped the same test at around the same time (#121484 and #121494)

Epic: none
Release note: None

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rail rail rail approved these changes

@stevendanna stevendanna Awaiting requested review from stevendanna stevendanna is a code owner automatically assigned from cockroachdb/disaster-recovery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickystewart @cockroach-teamcity @rail