Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: plpgsql: add support for CALL statements #121743

Merged
merged 3 commits into from Apr 5, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 3, 2024

Backport 3/3 commits from #121319 on behalf of @DrewKimball.

/cc @cockroachdb/release


opt/optbuilder: reset builder context for nested routines

This commit resets the Builder.insideDataSource field in the optbuilder
when building the body of a routine. This is necessary since a nested
routine is not (necessarily) inside a data source, even if its parent it.

Fixes #121316

Release note: None

plpgsql/parser: add parser support for CALL statements

This commit adds support in the PL/pgSQL parser for CALL statements
within a PL/pgSQL routine.

Informs #120818

Release note: None

plpgsql: implement CALL statements

This commit adds support for the PL/pgSQL CALL statement. This allows
a PL/pgSQL routine to execute a stored procedure. Note that there is
a behavior difference vs SQL CALL statements: if the stored procedure
has OUT parameters, the surrounding routine passes variables in each
OUT parameter position, and the result of the procedure is assigned to
those variables.

Fixes #120818

Release note (sql change): Added support for PL/pgSQL CALL statements.
It is now possible to call a stored procedure from a PL/pgSQL routine.


Release justification: low-risk new functionality

This commit resets the `Builder.insideDataSource` field in the optbuilder
when building the body of a routine. This is necessary since a nested
routine is not (necessarily) inside a data source, even if its parent it.

Fixes #121316

Release note: None
This commit adds support in the PL/pgSQL parser for CALL statements
within a PL/pgSQL routine.

Informs #120818

Release note: None
This commit adds support for the PL/pgSQL CALL statement. This allows
a PL/pgSQL routine to execute a stored procedure. Note that there is
a behavior difference vs SQL CALL statements: if the stored procedure
has OUT parameters, the surrounding routine passes variables in each
OUT parameter position, and the result of the procedure is assigned to
those variables.

Fixes #120818

Release note (sql change): Added support for PL/pgSQL CALL statements.
It is now possible to call a stored procedure from a PL/pgSQL routine.
@blathers-crl blathers-crl bot requested review from a team as code owners April 3, 2024 22:58
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-121319 branch from 1998aca to 5657b73 Compare April 3, 2024 22:58
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 3, 2024
@blathers-crl blathers-crl bot requested review from stevendanna and removed request for a team April 3, 2024 22:58
Copy link
Author

blathers-crl bot commented Apr 3, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from yuzefovich, DrewKimball and mgartner and removed request for a team April 3, 2024 22:58
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 3, 2024
Copy link
Author

blathers-crl bot commented Apr 3, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 4 of 4 files at r2, 23 of 23 files at r3, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball, @mgartner, and @stevendanna)

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, 4 of 4 files at r2, 23 of 23 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @stevendanna)

@DrewKimball DrewKimball requested a review from rafiss April 4, 2024 17:37
@yuzefovich
Copy link
Member

Merging so that I can backport on top if it.

@yuzefovich yuzefovich merged commit ab15ba5 into release-24.1 Apr 5, 2024
33 of 34 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-24.1-121319 branch April 5, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants