release-23.1: util/mon: add cluster setting for disabling monitor tree tracking #121746
+17
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #121722.
/cc @cockroachdb/release
We already have an env var for this, but it requires a node restart to apply. Having a cluster setting will allow us to disable the monitor tree tracking without the node restart, but it might also help us prove that it's Go GC deficiency to blame for the suspected memory leak: namely, if we find a cluster that has the leak and disable the tree tracking via the cluster setting, if it's Go GC deficiency, the leak would be cleaned up; if it's CRDB memory leak, then the leak will remain but will stop growing.
Epic: None
Release note: None
Release justification: low-risk improvement.