-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: update tpcc overload #121833
roachtest: update tpcc overload #121833
Conversation
9f0df24
to
a32d8c4
Compare
Previously this test was created but wasn't run since it would always fail. The test still doesn't pass in the default configuration, however after the addition of cockroachdb#118781, at least it is possible to configure a cluster to pass. Informs: cockroachdb#110272 Informs: cockroachdb#89142 Release note: None
a32d8c4
to
a4cdb4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is great, and nice experiment!
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @renatolabs and @srosenberg)
TFTR! bors r=rafiss |
The reason for the 4h ramp is to allow a more gradual change from "sustainable to unsustainable" and watch the impact as it changes. The backups were not really intentional, but when I noticed them I didn't remove them since in the customer case they were somewhat impacted by backups. It would probably be cleaner to remove them. From a rebalance perspective, it would be good to better understand if they converge over time and if not why not. |
My run flaked out after about 75 min of the tpcc workload running due to. This was with
|
Previously this test was created but wasn't run since it would always fail. The test still doesn't pass in the default configuration, however after the addition of #118781, at least it is possible to configure a cluster to pass.
Informs: #110272
Informs: #89142
Release note: None