Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: ui: index recommendations properly handle quoted table names #122120

Merged
merged 1 commit into from
Apr 11, 2024

Commits on Apr 3, 2024

  1. ui: index recommendations properly handle quoted table names

    Fixes: #119579
    
    The UI code used to modify the index recommendations provided by the
    server was not properly accounting for table and column names containing
    quotation marks. This was causing invalid CREATE INDEX statements to
    be generated, which would fail on request.
    
    This patch fixes this by updating the query modification code to strip
    quotation marks from the table name prior to using it to generate an
    index name.
    
    Release note (bug fix): Index recommendations in the DB Console will now
    function properly for indexes on tables/columns whose names contain
    quotation marks and/or whitespace.
    For example: `CREATE INDEX ON "my table" ("my col");`
    abarganier committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    6348d46 View commit details
    Browse the repository at this point in the history