release-23.2: stats: set the type resolver when dealing with virtual comp cols #122319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #122313 on behalf of @yuzefovich.
/cc @cockroachdb/release
We forgot to set the type resolver on the sema context that we create when dealing with virtual computed columns, and as a result stats collection on tables with such columns now might fail altogether. In a separate change I'll audit all callers of
MakeSemaContext
to prevent such a mistake in the future.Fixes: #122312.
Release note (bug fix): CockroachDB could fail to collect table statistics on tables that have virtual computed columns of user-defined type if
sql.stats.virtual_computed_columns.enabled
cluster setting is enabled. The setting is introduced in 23.2.4 version and is disabled by default, so only this particular version is affected with non-default setting.Release justification: bug fix.