Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: stats: set the type resolver when dealing with virtual comp cols #122320

Merged
merged 1 commit into from Apr 16, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 13, 2024

Backport 1/1 commits from #122313 on behalf of @yuzefovich.

/cc @cockroachdb/release


We forgot to set the type resolver on the sema context that we create when dealing with virtual computed columns, and as a result stats collection on tables with such columns now might fail altogether. In a separate change I'll audit all callers of MakeSemaContext to prevent such a mistake in the future.

Fixes: #122312.

Release note (bug fix): CockroachDB could fail to collect table statistics on tables that have virtual computed columns of user-defined type if sql.stats.virtual_computed_columns.enabled cluster setting is enabled. The setting is introduced in 23.2.4 version and is disabled by default, so only this particular version is affected with non-default setting.


Release justification: bug fix.

We forgot to set the type resolver on the sema context that we create
when dealing with virtual computed columns, and as a result stats
collection on tables with such columns now might fail altogether. In
a separate change I'll audit all callers of `MakeSemaContext` to prevent
such a mistake in the future.

Release note (bug fix): CockroachDB could fail to collect table
statistics on tables that have virtual computed columns of user-defined
type if `sql.stats.virtual_computed_columns.enabled` cluster setting is
enabled. The setting is introduced in 23.2.4 version and is disabled by
default, so only this particular version is affected with non-default
setting.
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 13, 2024 00:42
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-122313 branch from 2de8286 to 596df06 Compare April 13, 2024 00:42
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 13, 2024 00:42
@blathers-crl blathers-crl bot requested review from michae2 and removed request for a team April 13, 2024 00:42
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 13, 2024
Copy link
Author

blathers-crl bot commented Apr 13, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 13, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich yuzefovich merged commit a4896de into release-24.1 Apr 16, 2024
19 of 20 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-24.1-122313 branch April 16, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants