Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: rpc,security,sql,cli: Add subject_required cluster setting #122368

Merged
merged 1 commit into from Apr 15, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 15, 2024

Backport 2/2 commits from #122105 on behalf of @souravcrl.

/cc @cockroachdb/release


Previous in sequence: #120786
informs #110616, #118750
fixes CRDB-35884
Epic CRDB-34126

Release note (security update): We are adding a cluster setting
security.client_cert.subject_required.enabled which mandates a requirement for
role subject to be set either through subject role option or
root-cert-distinguished-name and node-cert-distinguished-name. It controls both
RPC access and login via authCert.


Release justification: the feature needs to be part of 24.1 release as part of epic, it completes a sequence of changes.

@blathers-crl blathers-crl bot requested a review from a team as a code owner April 15, 2024 15:47
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-122105 branch from f3c686e to ba8667c Compare April 15, 2024 15:47
@blathers-crl blathers-crl bot requested review from a team as code owners April 15, 2024 15:47
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 15, 2024
Copy link
Author

blathers-crl bot commented Apr 15, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 15, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@souravcrl souravcrl requested a review from bdarnell April 15, 2024 17:03
@rafiss rafiss requested a review from souravcrl April 15, 2024 17:48
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @blathers-crl[bot] and @souravcrl)


-- commits line 14 at r1:
does this need a release note to document the new public cluster setting?

Copy link
Contributor

@souravcrl souravcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)


-- commits line 14 at r1:

Previously, rafiss (Rafi Shamim) wrote…

does this need a release note to document the new public cluster setting?

Added a release note to PR description.

@souravcrl souravcrl force-pushed the blathers/backport-release-24.1-122105 branch from ba8667c to 56a94ca Compare April 15, 2024 18:47
Copy link
Contributor

@souravcrl souravcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)


-- commits line 14 at r1:

Previously, souravcrl wrote…

Added a release note to PR description.

updated the release note in the commit message also.

@rafiss rafiss requested a review from souravcrl April 15, 2024 18:54
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @blathers-crl[bot] and @souravcrl)


-- commits line 9 at r3:
minor nit: the release note should have a category, like Release note (security update)

see: https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/186548364/Release+notes#Categories

also, instead of "We will be adding a cluster setting ..." the grammar should be in past or present tense. for example, "Added a cluster setting which mandates ..."

see: https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/186548364/Release+notes#Descriptions

feel free to merge once addressed

Previous in sequence: #120786
informs #110616, #118750
fixes CRDB-35884
Epic CRDB-34126

Release note (security update): We are adding a cluster setting
`security.client_cert.subject_required.enabled` which mandates a requirement for
role subject to be set either through subject role option or
root-cert-distinguished-name and node-cert-distinguished-name. It controls both
RPC access and login via authCert.
@souravcrl souravcrl force-pushed the blathers/backport-release-24.1-122105 branch from 56a94ca to 12d3238 Compare April 15, 2024 19:05
@craig
Copy link
Contributor

craig bot commented Apr 15, 2024

👎 Rejected by label

Copy link
Contributor

@souravcrl souravcrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)


-- commits line 9 at r3:

Previously, rafiss (Rafi Shamim) wrote…

minor nit: the release note should have a category, like Release note (security update)

see: https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/186548364/Release+notes#Categories

also, instead of "We will be adding a cluster setting ..." the grammar should be in past or present tense. for example, "Added a cluster setting which mandates ..."

see: https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/186548364/Release+notes#Descriptions

feel free to merge once addressed

Addressed the above. I have gone through the doc, will be mindful of these when making visible changes.

TRFR!

@souravcrl souravcrl merged commit 3ce69af into release-24.1 Apr 15, 2024
19 of 20 checks passed
@souravcrl souravcrl deleted the blathers/backport-release-24.1-122105 branch April 15, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants