staging-v23.1.19: release-23.1: sql: regulate MODIFYCLUSTERSETTING with cluster setting #122455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
This PR introduces the cluster setting sql.auth.modify_cluster_setting_applies_to_all.enabled which determines whether users with MODIFYCLUSTERSETTING are able to edit non sql.defaults settings. It also allows this setting to prevent viewing sql.default settings. Additionally, a deprecation warning is added for this cluster setting to inform that it should be replaced once the cluster is finalized Fixes: #122023 Release note (bug fix): reintroduce sql.auth.modify_cluster_setting_applies_to_all.enabled so that mixed version clusters can migrate off this setting.
blathers-crl
bot
force-pushed
the
blathers/backport-staging-v23.1.19-122055
branch
from
016db36
to
f02cec2
Compare
blathers-crl
bot
added
blathers-backport
|
This change is |
dhartunian
approved these changes
Apr 16, 2024
rafiss
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #122055 on behalf of @fqazi.
/cc @cockroachdb/release
This PR introduces the cluster setting
sql.auth.modify_cluster_setting_applies_to_all.enabled which determines
whether users with MODIFYCLUSTERSETTING are able to edit non
sql.defaults settings. It also allows this setting to prevent viewing
sql.default settings. Additionally, a deprecation warning is added for
this cluster setting to inform that it should be replaced once the
cluster is finalized
Fixes: #122023
Release justification: important bug fix
Release note (bug fix): reintroduce
sql.auth.modify_cluster_setting_applies_to_all.enabled so that mixed
version clusters can migrate off this setting.
Release justification: