-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: schemachanger: consider column target status after resolving #122631
Conversation
54f791f
to
2c35eda
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 17 of 17 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @annrpom and @rafiss)
getting edit: i force-pushed to this branch as per https://cockroachlabs.slack.com/archives/CJ0H8Q97C/p1648648510522509?thread_ts=1648638969.754059&cid=CJ0H8Q97C |
Previously, using the "comma syntax" for dropping a col with the same name (`alter table t drop column i, drop column i;`) led to an internal error. This patch makes it so that the error will instead be a proper external error by ensuring that resolving columns in the DSC considers the "dropping" state. Epic: none Release note: None
This patch enables the "comma syntax" to drop and add a column with the same name in our DSC. Epic: none Fixes: #120226 Release note (bug fix): Dropping and adding a column with the same name no longer results in a "column already exists error".
2c35eda
to
406c69a
Compare
Backport 2/2 commits from #122389 on behalf of @annrpom.
/cc @cockroachdb/release
schemachanger: consider "dropping" columns during drop col
Previously, using the "comma syntax" for dropping a col
with the same name (
alter table t drop column i, drop column i;
)led to an internal error. This patch makes it so that
the error will instead be a proper external error by
ensuring that resolving columns in the DSC considers the
"dropping" state.
Epic: none
Release note: None
schemachanger: consider "dropping" columns while adding col
This patch enables the "comma syntax" to drop and add
a column with the same name in our DSC.
Epic: none
Fixes: #120226
Release note (bug fix): Dropping and adding a column with the same
name no longer results in a "column already exists error".
Release justification: bug fix