-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: sql: add external connection info to show grants #122823
Merged
Dedej-Bergin
merged 2 commits into
cockroachdb:release-24.1
from
Dedej-Bergin:backport24.1-122197-122556
Apr 22, 2024
Merged
release-24.1: sql: add external connection info to show grants #122823
Dedej-Bergin
merged 2 commits into
cockroachdb:release-24.1
from
Dedej-Bergin:backport24.1-122197-122556
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used the relation_name column to show all objects however we now have objects such as function and types that are not relations so the name of this column was changed to object_name in these code changes. Additionally with the larger variety in types a new column object_type is added that identifies the type of an object. Fixes: cockroachdb#119775 Release note (sql change): object_type can now be seen with the show grants command and relation_name column is now shown as object_name.
Previously, when we run the SHOW GRANTS command external connection info would not show up. These code changes make it so that we can now see external connection granted privileges with the SHOW GRANTS command. Fixes: cockroachdb#122199 Release note (sql change): external connection granted privileges can now be seen with the SHOW GRANTS command.
Dedej-Bergin
requested review from
dt and
rytaft
and removed request for
a team
April 22, 2024 17:41
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
Label PR's that are backports to older release branches
label
Apr 22, 2024
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
rafiss
changed the title
release-24.1: TODO
release-24.1: sql: add external connection info to show grants
Apr 22, 2024
rafiss
approved these changes
Apr 22, 2024
Dedej-Bergin
merged commit Apr 22, 2024
98db771
into
cockroachdb:release-24.1
18 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
/cc @cockroachdb/release
Release justification: fix for a bug where external connections are not shown when you are not admin,
or not shown on the show grants command at all.