Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql: add external connection info to show grants #122823

Merged

Conversation

Dedej-Bergin
Copy link
Contributor

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: fix for a bug where external connections are not shown when you are not admin,
or not shown on the show grants command at all.

Previously, we used the relation_name column to show all objects
however we now have objects such as function and types that
are not relations so the name of this column was changed to object_name
in these code changes. Additionally with the larger variety in types
a new column object_type is added that identifies the type of an object.

Fixes: cockroachdb#119775
Release note (sql change): object_type can now be seen with the show grants
command and relation_name column is now shown as object_name.
Previously, when we run the SHOW GRANTS command external connection info
would not show up.  These code changes make it so that we can now see
external connection granted privileges with the SHOW GRANTS command.

Fixes: cockroachdb#122199
Release note (sql change): external connection granted privileges can now
be seen with the SHOW GRANTS command.
@Dedej-Bergin Dedej-Bergin requested review from a team as code owners April 22, 2024 17:41
@Dedej-Bergin Dedej-Bergin requested review from dt and rytaft and removed request for a team April 22, 2024 17:41
Copy link

blathers-crl bot commented Apr 22, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 22, 2024
Copy link

blathers-crl bot commented Apr 22, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss changed the title release-24.1: TODO release-24.1: sql: add external connection info to show grants Apr 22, 2024
@Dedej-Bergin Dedej-Bergin merged commit 98db771 into cockroachdb:release-24.1 Apr 22, 2024
18 of 20 checks passed
@Dedej-Bergin Dedej-Bergin deleted the backport24.1-122197-122556 branch April 22, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants