-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: optbuilder: add missing continuation pop #122939
release-24.1: optbuilder: add missing continuation pop #122939
Conversation
This commit fixes a missing `pop` of the continuation after having built the corresponding nested block (we had 4 pushes and 3 pops). This could manifest as an internal error. Fixes: #122873. Release note (bug fix): Previously, CockroachDB could run in an internal error when evaluating PLpgSQL routines with nested blocks in some cases. The bug is only present in 24.1.0-beta versions and is now fixed.
d822abc
to
aac06fe
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @michae2 and @yuzefovich)
Backport 1/1 commits from #122920 on behalf of @yuzefovich.
/cc @cockroachdb/release
This commit fixes a missing
pop
of the continuation after having built the corresponding nested block (we had 4 pushes and 3 pops). This could manifest as an internal error.Fixes: #122873.
Release note (bug fix): Previously, CockroachDB could run in an internal error when evaluating PLpgSQL routines with nested blocks in some cases. The bug is only present in 24.1.0-beta versions and is now fixed.
Release justification: bug fix.