Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: jobs: avoid errors related to fraction completed #122965

Merged
merged 1 commit into from
May 1, 2024

Conversation

stevendanna
Copy link
Collaborator

@stevendanna stevendanna commented Apr 24, 2024

Backport 1/2 commits from #122674.

/cc @cockroachdb/release


Release justification: Bug fix for bug that results in failed backup.

@stevendanna stevendanna requested review from a team as code owners April 24, 2024 09:14
@stevendanna stevendanna requested review from msbutler and removed request for a team April 24, 2024 09:14
Copy link

blathers-crl bot commented Apr 24, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 24, 2024
Copy link

blathers-crl bot commented Apr 24, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler
Copy link
Collaborator

msbutler commented May 1, 2024

flake in unit test. rerunning ci

FractionProgressed is used by jobs that do a substantial amount of
work. Failing the entire job because it has miscalculated its fraction
progressed estimate is not good.

Here, we leave the error state for non-release builds but log in
release builds.

Epic: none

Release note (bug fix): A job will now log rather than fail if it
reports an out-of bound progress fraction.
@msbutler
Copy link
Collaborator

msbutler commented May 1, 2024

rebased to restart ci

@msbutler msbutler merged commit 03021e9 into cockroachdb:release-24.1 May 1, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants