-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: jobs: avoid errors related to fraction completed #122965
release-24.1: jobs: avoid errors related to fraction completed #122965
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
flake in unit test. rerunning ci |
FractionProgressed is used by jobs that do a substantial amount of work. Failing the entire job because it has miscalculated its fraction progressed estimate is not good. Here, we leave the error state for non-release builds but log in release builds. Epic: none Release note (bug fix): A job will now log rather than fail if it reports an out-of bound progress fraction.
6fe2a9d
to
bf8ee17
Compare
rebased to restart ci |
Backport 1/2 commits from #122674.
/cc @cockroachdb/release
Release justification: Bug fix for bug that results in failed backup.