Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.1: kvserver: split upreplication from recovery metrics #123055

Merged
merged 1 commit into from
May 1, 2024
Merged

release-24.1: kvserver: split upreplication from recovery metrics #123055

merged 1 commit into from
May 1, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 25, 2024 •
edited by andrewbaptist

Backport 1/1 commits from #119028 on behalf of @andrewbaptist.

/cc @cockroachdb/release

Previously both raft recovery and upreplication snapshots were counted as recovery metrics. This PR splits them into two separate categories.

Epic: none
Fixes: #115729

Release note (ops change): Adds 2 new metrics
range.snapshots.upreplication.rcvd-bytes and
range.snapshots.upreplication.sent-bytes. It also changes the meaning of range.snapshots.recovery.rcvd-bytes and
range.snapshots.recovery.sent-bytes to only include raft snapshots.

Release justification: Change to only the metrics, and having this split out will help with observability of snapshot issues.

@andrewbaptist
kvserver: split upreplication from recovery metrics
14ae779 
Previously both raft recovery and upreplication snapshots were counted
as recovery metrics. This PR splits them into two separate categories.

Epic: none
Fixes: #115729

Release note (ops change): Adds 2 new metrics
range.snapshots.upreplication.rcvd-bytes and
range.snapshots.upreplication.sent-bytes. It also changes the meaning of
range.snapshots.recovery.rcvd-bytes and
range.snapshots.recovery.sent-bytes to only include raft snapshots.
Additionally it adds the new line to the "Snapshot Data Received"
graph.
@blathers-crl blathers-crl bot requested review from a team as code owners April 25, 2024 13:20
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-119028 branch from 04d8e36 to 14ae779 Compare April 25, 2024 13:20
@blathers-crl blathers-crl bot requested review from abarganier and removed request for a team April 25, 2024 13:20
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 25, 2024
@blathers-crl blathers-crl bot requested review from kvoli and nkodali April 25, 2024 13:20
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Apr 25, 2024 •
edited by andrewbaptist

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 25, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist andrewbaptist merged commit 6cfb4f6 into release-24.1 May 1, 2024
19 of 20 checks passed
@andrewbaptist andrewbaptist deleted the blathers/backport-release-24.1-119028 branch May 1, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvoli kvoli kvoli approved these changes

@abarganier abarganier Awaiting requested review from abarganier abarganier is a code owner automatically assigned from cockroachdb/obs-prs

@nkodali nkodali Awaiting requested review from nkodali

Assignees

@andrewbaptist andrewbaptist

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @kvoli @andrewbaptist