release-24.1: backupccl: don't attempt to set GC TTL on NonPhysical table #123205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #123202 on behalf of @stevendanna.
/cc @cockroachdb/release
In #88342, we introduced code to reduce the GC TTL of tables to facilitate
faster cleanup in the case of a failed restore. This introduced a bug
in which the revert could fail because we are not able to set the
GC.TTL on non-physical tables.
Here, we exclude non-physical tables when lowering gc.ttlseconds and
also make this a warning instead of an error.
For releases where we've both moved to only inspecting the namespace
table for RESTORE collisions and where the default TTL is low, we
should consider removing this code completely.
Epic: none
Fixes #122168
Release note (bug fix): Fix a bug where a failed RESTORE could leave
the system in a state where re-attempting the restore was not possible
without manual intervention.
Release justification: Bug fix for a bug that causes descriptors to be permanently offline without manual intervention.