ui: add line graph for replication lag metric #123208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-cao
requested review from
srosenberg and
DarrylWong
and removed request for
a team
|
This change is |
kev-cao
force-pushed
the
ui/replicationLagMetric
branch
2 times, most recently
from
33081c4
to
fc3ef7b
Compare
xinhaoz
reviewed
Apr 29, 2024
...es/db-console/src/views/cluster/containers/nodeGraphs/dashboards/crossClusterReplication.tsx
Outdated
Show resolved
Hide resolved
xinhaoz
approved these changes
Apr 29, 2024
...es/db-console/src/views/cluster/containers/nodeGraphs/dashboards/crossClusterReplication.tsx
Outdated
Show resolved
Hide resolved
kev-cao
force-pushed
the
ui/replicationLagMetric
branch
from
fc3ef7b
to
ecffdc3
Compare
|
TFTR! bors r=xinhaoz |
|
Build failed:
|
There currently does not exist observability for replication lag in PCR in the DB Console. As replication lag is essentially RPO for customers, this metric should be made available to them in the dashboard. This commit adds the metric as the difference between the wall time and the reported replicated time. Fixes cockroachdb#120652 Release note (ui change): Added observability for PCR replication lag to the metrics dashboard
kev-cao
force-pushed
the
ui/replicationLagMetric
branch
from
ecffdc3
to
a9dfc64
Compare
|
bors r=xinhaoz |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from a9dfc64 to blathers/backport-release-24.1-123208: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently does not exist observability for replication lag in PCR in the DB Console. As replication lag is essentially RPO for customers, this metric should be made available to them in the dashboard. This commit adds the metric as the difference between the wall time and the reported replicated time.
Fixes #120652
Release note (ui change): Added observability for PCR replication lag to the metrics dashboard