Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: server: enable continuous CPU profiler #123244

Open
wants to merge 2 commits into
base: release-23.2
Choose a base branch
from
Open

release-23.2: server: enable continuous CPU profiler #123244

wants to merge 2 commits into from
+6 −4

Conversation

dhartunian
Copy link
Collaborator

@dhartunian dhartunian commented Apr 29, 2024 •
edited

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: high-priority need for functionality in production deployments

aadityasondhi and others added 2 commits April 29, 2024 15:27
@aadityasondhi @dhartunian
server: enable continuous CPU profiler
030f25b 
This patch enables the CPU profile with a threshold of 75% and a max
frequency of 20min.

The motivation for this change is that recently, I have noticed a few
cases during investigations where CPU utilization spikes but we lack
profiles after the fact. This hinders our ability to dig deeper into the
source of high CPU usage. Having profiles can help inform us of future
AC integrations that we may need, or other performance improvements we
can do elsewhere.

Informs cockroachdb#97699.

Release note (ops change): CRDB will now automatically generate CPU
profiles if there is an increase in CPU utilization. This can help
investigate possible issues after the fact.
@yuzefovich @dhartunian
profiler: allow 0 value for CPU threshold
6dc6da5 
In 9036430 we added positive int
validation for `server.cpu_profile.cpu_usage_combined_threshold`, but
a value of zero also seems reasonable in some cases (the comment on the
setting also mentions it), so this commit switches to non-negative int
validation instead.

Epic: None

Release note: None
@dhartunian dhartunian requested review from a team as code owners April 29, 2024 19:27
@dhartunian dhartunian requested review from abarganier and removed request for a team April 29, 2024 19:27
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Apr 29, 2024 •
edited by dhartunian

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 29, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Apr 29, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian
Copy link
Collaborator Author

I'm going to run some experiments with tpcc overload and see if I can evaluate the impact here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abarganier abarganier Awaiting requested review from abarganier abarganier was automatically assigned from cockroachdb/obs-inf-prs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dhartunian @cockroach-teamcity @aadityasondhi @yuzefovich