-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: sql: remove unneeded CREATE SEQUENCE priv check #123289
Conversation
Release note (bug fix): Previously, the CREATE SEQUENCE command would incorrectly check if the user had the CREATE privilege on the parent database if the legacy schema changer was being used. This was incorrect, and that check is now removed. The command only needs CREATE privilege on the parent schema now.
bd86245
to
03aa991
Compare
b6de3a9
to
89bca0b
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Backport 1/1 commits from #123263 on behalf of @rafiss.
/cc @cockroachdb/release
fixes #123251
Release note (bug fix): Previously, the CREATE SEQUENCE command would incorrectly check if the user had the CREATE privilege on the parent database if the legacy schema changer was being used. This was incorrect, and that check is now removed. The command only needs CREATE privilege on the parent schema now.
Release justification: bug fix