Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1: sql: remove unneeded CREATE SEQUENCE priv check #123289

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 30, 2024

Backport 1/1 commits from #123263 on behalf of @rafiss.

/cc @cockroachdb/release


fixes #123251

Release note (bug fix): Previously, the CREATE SEQUENCE command would incorrectly check if the user had the CREATE privilege on the parent database if the legacy schema changer was being used. This was incorrect, and that check is now removed. The command only needs CREATE privilege on the parent schema now.


Release justification: bug fix

Release note (bug fix): Previously, the CREATE SEQUENCE command would
incorrectly check if the user had the CREATE privilege on the parent
database if the legacy schema changer was being used. This was
incorrect, and that check is now removed. The command only needs CREATE
privilege on the parent schema now.
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 30, 2024 15:45
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-123263 branch from bd86245 to 03aa991 Compare April 30, 2024 15:45
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 30, 2024
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1-123263 branch from b6de3a9 to 89bca0b Compare April 30, 2024 15:45
@blathers-crl blathers-crl bot requested a review from fqazi April 30, 2024 15:45
Copy link
Author

blathers-crl bot commented Apr 30, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 30, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

@rafiss rafiss merged commit a42827c into release-24.1 Apr 30, 2024
19 of 20 checks passed
@rafiss rafiss deleted the blathers/backport-release-24.1-123263 branch April 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants