workload: retry errors when tolerate-errors is set #123305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andrewbaptist
force-pushed
the
2024-04-29-tolerate-errors-retry
branch
4 times, most recently
from
f3647df
to
b3056a4
Compare
Release note: None
Previously the limiter would respond to a cluster slowdown by slowing down its rate if --max-rate was set, and it would never recover the missed requests. With this change it will save the missed requests in the limiters burst and issue requests faster after the cluster can go faster. This turns the --max-rate into a maximum over a longer interval rather than always starting from now. As part of this change the workload is ramped up more consistently if max rate is set by both ramping up the number of workers as well as the number of requests per second each worker makes. Previously --max-rate and --ramp did not play well together. Release note: None
Previously if tolerate errors was set, the workload would log and drop errors. Now it will retry the errors. This more closely simulates how clients would use our system. Informs: cockroachdb#123304 Epic: none Release note: None
andrewbaptist
force-pushed
the
2024-04-29-tolerate-errors-retry
branch
from
b3056a4
to
b646fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if tolerate errors was set, the workload would log and drop errors. Now it will retry the errors. This more closely simulates how clients would use our system.
Informs: #123304
Epic: none
Release note: None