roachtest: change network_logging to buffered_logging, include files
#123431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses: cockroachdb#120759 Previously, the `network_logging` roachtest was created to put the `bufferedSink` (an async producer+consumer buffer that we primarily use to wrap network log sinks) through its paces. Originally, this functionality was only available to network (`fluent`,`http`) log sinks, and so the test did not include any file based log sinks. As of cockroachdb#120428, we now support the ability to use async buffering on `file-group` log sinks as well, via the same `bufferedSink`. Therefore, it makes sense that we should expand our existing `network_logging` roachtest to also include file sinks. This commit does so by expanding the log config to enable async buffering for files by default, and adds three `file-groups` log sinks to the config that capture all log channels. This will now run alongside the existing network logging sinks. As a final step, since this test is no longer specific to network logging, we rename the roachtest from `network_logging` to `buffered_logging`. Release note: none
abarganier
requested review from
a team and
xinhaoz
and removed request for
a team
abarganier
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
This change is |
dhartunian
approved these changes
May 2, 2024
|
TFTR! bors r=dhartunian |
craig bot
pushed a commit
that referenced
this pull request
May 3, 2024
123431: roachtest: change `network_logging` to `buffered_logging`, include files r=dhartunian a=abarganier Addresses: #120759 Previously, the `network_logging` roachtest was created to put the `bufferedSink` (an async producer+consumer buffer that we primarily use to wrap network log sinks) through its paces. Originally, this functionality was only available to network (`fluent`,`http`) log sinks, and so the test did not include any file based log sinks. As of #120428, we now support the ability to use async buffering on `file-group` log sinks as well, via the same `bufferedSink`. Therefore, it makes sense that we should expand our existing `network_logging` roachtest to also include file sinks. This commit does so by expanding the log config to enable async buffering for files by default, and adds three `file-groups` log sinks to the config that capture all log channels. This will now run alongside the existing network logging sinks. As a final step, since this test is no longer specific to network logging, we rename the roachtest from `network_logging` to `buffered_logging`. Release note: none Epic: CRDB-35401 Co-authored-by: Alex Barganier <abarganier@cockroachlabs.com>
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #120759
Previously, the
network_loggingroachtest was created to put thebufferedSink(an async producer+consumer buffer that we primarily use to wrap network log sinks) through its paces. Originally, this functionality was only available to network (fluent,http) log sinks, and so the test did not include any file based log sinks.As of #120428, we now support the ability to use async buffering on
file-grouplog sinks as well, via the samebufferedSink. Therefore, it makes sense that we should expand our existingnetwork_loggingroachtest to also include file sinks.This commit does so by expanding the log config to enable async buffering for files by default, and adds three
file-groupslog sinks to the config that capture all log channels. This will now run alongside the existing network logging sinks.As a final step, since this test is no longer specific to network logging, we rename the roachtest from
network_loggingtobuffered_logging.Release note: none
Epic: CRDB-35401