Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: update drtprod create drt-large #123464

Merged
merged 2 commits into from
May 17, 2024

Conversation

herkolategan
Copy link
Collaborator

Bring the creation in line with what is currently running on cockroach-drt. Uses zone expansion to balance the nodes evenly across regions.

Epic: None
Release Note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

scripts/drtprod Outdated
@@ -128,17 +128,21 @@ EOF"
fi
case "${2}" in
"drt-main")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Change this to drt-large too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, was about to double check this before moving it out of draft, thanks for pointing it out!

@herkolategan herkolategan marked this pull request as ready for review May 3, 2024 11:58
@herkolategan herkolategan requested a review from ajstorm May 3, 2024 11:58
Copy link
Member

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/drtprod Outdated
--clouds gce \
--gce-managed \
--gce-zones "us-east1-b,us-west1-b,europe-west2-b" \
--gce-enable-multiple-stores \
--gce-zones "northamerica-northeast2-a:2,northamerica-northeast2-b:2,northamerica-northeast2-c:1,europe-central2-a:2,europe-central2-b:2,europe-central2-c:1,northamerica-northeast1-a:2,northamerica-northeast1-b:2,northamerica-northeast1-c:1" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we swap Warsaw for Columbus?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will update it before merging.

Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

Bring the creation in line with what is currently running on cockroach-drt. Uses
zone expansion to balance the nodes evenly across regions.

Epic: None
Release Note: None
In an effort to save cost on regional network transfers the Warsaw Europe Zone
will now be switched to Columbus.

Epic: None
Release Note: None
@herkolategan
Copy link
Collaborator Author

TFTRs!

bors r=itsbilal,ajstorm

@craig craig bot merged commit e3ab04b into cockroachdb:master May 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants