release-23.2.5-rc: changefeedccl: disable drain watcher by default #123596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #123370 on behalf of @wenyihu6.
/cc @cockroachdb/release
#102717 introduced a mechanism allowing for an orderly shutdown of changefeed
aggregators and an up-to-date frontier information to reduce duplicates during
a node restart in 23.2. However, we've recently identified a bug that could
lead to unexpected behavior. It's unclear where the bug is yet. This patch disables
this feature by default.
Fixes: #123371
Release note: Disabled a changefeed optimization on reducing duplicates during
aggregator restarts due to its bad performance.
Release justification: Low risk bug fix to disable a changefeed optimization on reducing duplicates during
aggregator restarts due to its unexpected behavior.