-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachprod: identify apt failures automatically and mark them as flakes #123725
roachprod: identify apt failures automatically and mark them as flakes #123725
Conversation
Previously, we used to get roachtest failures when the Ubuntu mirrors were down for a period of time. This PR identifies these apt failures and marks them as a flake. Epic: none Fixes: cockroachdb#103316 Release note: None
7ef99b0
to
488551c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick search shows it's not a bad assumption to say exit code 100
= apt
failure.
I did see one case where exit code 100
wasn't a transient error though, but I suppose the same could be true for SSH
. Maybe we just hope someone will notice if the same test keeps flaking every night 🤷
SGTM but maybe someone else has a different opinion
bors r+ |
blathers backport 24.1 23.2 |
blathers backport 23.1 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 488551c to blathers/backport-release-23.1-123725: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously, we used to get roachtest failures when the Ubuntu mirrors were down for a period of time.
This PR identifies these apt failures and marks them as a flake.
Epic: none
Fixes: #103316
Release note: None