Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachprod: identify apt failures automatically and mark them as flakes #123725

Merged

Conversation

vidit-bhat
Copy link
Contributor

Previously, we used to get roachtest failures when the Ubuntu mirrors were down for a period of time.

This PR identifies these apt failures and marks them as a flake.

Epic: none
Fixes: #103316
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, we used to get roachtest failures when the
Ubuntu mirrors were down for a period of time.

This PR identifies these apt failures and marks them as a flake.

Epic: none
Fixes: cockroachdb#103316

Release note: None
@vidit-bhat vidit-bhat force-pushed the roachprod-mark-apt-failure-as-flake branch from 7ef99b0 to 488551c Compare May 8, 2024 18:39
@vidit-bhat vidit-bhat marked this pull request as ready for review May 8, 2024 18:40
@vidit-bhat vidit-bhat requested a review from a team as a code owner May 8, 2024 18:40
@vidit-bhat vidit-bhat requested review from herkolategan and renatolabs and removed request for a team May 8, 2024 18:40
Copy link
Contributor

@DarrylWong DarrylWong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick search shows it's not a bad assumption to say exit code 100 = apt failure.

I did see one case where exit code 100 wasn't a transient error though, but I suppose the same could be true for SSH. Maybe we just hope someone will notice if the same test keeps flaking every night 🤷

SGTM but maybe someone else has a different opinion

@vidit-bhat
Copy link
Contributor Author

bors r+

@craig craig bot merged commit fc8482f into cockroachdb:master May 9, 2024
22 checks passed
@renatolabs
Copy link
Collaborator

blathers backport 24.1 23.2

@vidit-bhat
Copy link
Contributor Author

blathers backport 23.1

Copy link

blathers-crl bot commented May 29, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 488551c to blathers/backport-release-23.1-123725: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: identify apt failures automatically and mark them as flakes
5 participants