sql: fix TestValidationWithProtectedTS flake #123750
Merged
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the test TestValidationWithProtectedTS would hang if a Go routine would hit an error, since a channel would not be posted. It would also not gracefully handle TS after replica GC errors on transactions, which could happen on overloaded machines. To address this patch makes the test more resilient to the Go routine hitting errors so that it doesn't time out, and adds retry logic for TS after replica GC errors. Fixes: cockroachdb#123447 Release note: None
|
This change is |
rafiss
approved these changes
May 9, 2024
|
@rafiss TFTR! bors r+ |
|
blathers backport 24.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the test TestValidationWithProtectedTS would hang if a Ggio routine would hit an error, since a channel would not be posted on a error. It would also not gracefully handle TS after replica GC errors on transactions, which could happen on overloaded machines. To address this patch makes the test more resilient to the Go routine hitting errors so that it doesn't time out, and adds retry logic for TS after replica GC errors.
Fixes: #123447
Release note: None