release-24.1: sqlstats: generate PCT_RUNTIME sort when requested #123903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #123846 on behalf of @dhartunian.
/cc @cockroachdb/release
Previously, when a request was made to the combined stats endpoint on CRDB with a
PCT_RUNTIME
sort, we'd default to asvcLatency
sort instead because of a missing switch case.This change fills that gap and adds some datadriven tests to inspect the resulting
WHERE
clauses.Fixes: #123841
Epic: CRDB-37544
Release note (ui change): Viewing SQL Activity sorted by
% of Runtime
now correctly sorts entries by the runtime amount.Release justification: low-risk, high-impact bugfix for sql stats