Commits on May 9, 2024

1. skip: remove skip.UnderStressRace{,WithIssue} …

   ... and replace with `UnderRace`.
   
   We are eliminating our use of https://github.com/cockroachdb/stress in
   `cockroachdb/cockroach` CI. In our nightlies on `master` and
   `release-24.1`, we are already not using `stress` (in favor of remote
   execution). It's still used in some nightlies (like the Pebble nightly)
   and Bazel Extended CI, though these uses will presumably be reduced as
   well.
   
   Meanwhile, the difference between these two functions is not clear and
   it's not always obvious which you should pick. Prior to the remote
   execution-based "stress" nightly, *either* would work. With remote
   execution, only `skip.UnderRace` works (as this is not "stress" as far
   as `skip` is concerned). This is confusing.
   
   Even before we were using remote execution, we were running the nightly
   `stressrace` with only one concurrent test run, so this was not any more
   "stressful" than not using `stress`, further confusing which `skip`
   function was appropriate to use.
   
   We migrate instead to simply having one function: `skip.UnderRace`.
   
   Epic: none
   
   Release note: None

   

   rickystewart committed May 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 0e60ced
   • Browse repository at this point

   Copy the full SHA

   0e60ced View commit details

   Browse the repository at this point in the history