-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build,compose: build libgeos for compose tests #123971
Conversation
8008a28
to
2e608ec
Compare
test: | ||
# We use a docker image mirror to avoid pulling from 3rd party repos, which sometimes have reliability issues. | ||
# See https://cockroachlabs.atlassian.net/wiki/spaces/devinf/pages/3462594561/Docker+image+sync for the details. | ||
image: us-east1-docker.pkg.dev/crl-docker-sync/docker-mirror/docker.io/library/ubuntu:xenial-20170214 | ||
environment: | ||
- COCKROACH_DEV_LICENSE=$COCKROACH_DEV_LICENSE | ||
- COCKROACH_RUN_COMPOSE_COMPARE=${COCKROACH_RUN_COMPOSE_COMPARE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure how these tests were running at all before this change. Do you know @rickystewart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it looks like this is something I missed in 156d9c9c9050df77f38db04a0187503e2edf5cbe
. So the thing has been effectively skipped since last week. Thanks for catching this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means this has to be backported to release-24.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to backport anyway, since the "missing libgeos library" error is/was happening on all active branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change won't backport cleanly to release-23.2
or prior, the basic idea should still apply though.
26d61a1
to
fcfcb85
Compare
TFTR! I was able to test the I guess I can try trigger a build from this PR's branch like this (?): https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Nightlies_ComposeTestsBazel/15245803?hideProblemsFromDependencies=false&hideTestsFromDependencies=false |
Release note: None
fcfcb85
to
8cd7566
Compare
bors r+ |
blathers backport 24.1 23.2 23.1 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-24.1-123971 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/124062/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 24.1 failed. See errors above. error creating merge commit from 8cd7566 to blathers/backport-release-23.2-123971: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. error creating merge commit from 8cd7566 to blathers/backport-release-23.1-123971: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This also includes some changes that make the test easier to debug by adding more logging.
fixes #122079
fixes #121592
fixes #121531
fixes #122339
Release note: None