Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvclient: separate out proxy sending #124066

Merged
merged 2 commits into from
Jun 24, 2024
Merged

kvclient: separate out proxy sending #124066

merged 2 commits into from
Jun 24, 2024

Commits on Jun 24, 2024

  1. kvclient: verify a proxy request is not split 

    If a proxy request is against a range which is subsequently split, the
request should still follow what the original client requested rather
than the updated cache. This prevents complex errors from split requests
as they can't be processed correctly.

Informs: cockroachdb#123965

Release note: None
    @andrewbaptist
    andrewbaptist committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cd5efb1 View commit details
    Browse the repository at this point in the history

  2. kvclient: separate out proxy sending 

    Previously in DistSender, a proxy request was handled using the same
logic within sendPartialBatch and sendToReplicas. There were short
circuits to handle the different cases of retries, but in cases with
changing range boundaries, it could return the wrong error. This change
intercepts proxy request at the start of DistSender.Send and sends to
the transport bypassing the rest of the DistSender retry logic. This
simplifies the code for proxy requests.

Epic: none
Fixes: cockroachdb#123965
Informs: cockroachdb#123146

Release note: None
    @andrewbaptist
    andrewbaptist committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    3367aa0 View commit details
    Browse the repository at this point in the history