-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: pgwire: change sql.defaults.results_buffer.size default to 512KiB #124633
Conversation
When this setting was added in PR #32366, the default value did not receive much scrutiny. Using a bigger value is beneficial since it will reduce the chance for clients using READ COMMITTED transactions to hit errors that cannot automatically be retried within CockroachDB. (The reason being that if results were already sent back to the client since the buffer filled up, it's not safe to retry that operation.) 512KiB is still pretty small, but should prevent more errors than the old default of 16KiB. Release note (sql change): The default value of the sql.defaults.results_buffer.size cluster setting was changed from 16KiB to 512KiB.
dc67628
to
2569926
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kyle-a-wong and @nvanbenschoten)
This avoids a race when setting a cluster setting, and instead sets the parameter directly in the connection string. Release note: None
Backport 1/1 commits from #124580 on behalf of @rafiss.
/cc @cockroachdb/release
When this setting was added in PR #32366, the default value did not receive much scrutiny. Using a bigger value is beneficial since it will reduce the chance for clients using READ COMMITTED transactions to hit errors that cannot automatically be retried within CockroachDB. (The reason being that if results were already sent back to the client since the buffer filled up, it's not safe to retry that operation.)
512KiB is still pretty small, but should prevent more errors than the old default of 16KiB.
fixes #124049
Release note (sql change): The default value of the sql.defaults.results_buffer.size cluster setting was changed from 16KiB to 512KiB.
Release justification: low risk high benefit config change