sql: move ValidateNoRepeatKeysInZone to zonepb pkg #124766
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Seems like a straightforward and reasonable refactor to me.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @annrpom)
pkg/config/zonepb/zone.go line 1319 at r1 (raw file):
} // ValidateNoRepeatKeysInZone checks that there are not duplicated values for a particular
nit: should we limit this comment line to 80 characters? I like that it was updated to include the function name, but it seems out of alignment with the other lines in the comment block now.
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:
This patch refactors the `ValidateNoRepeatKeysInZone` function to a package accesible to the DSC. Informs: cockroachdb#117574 Release note: None
|
TFTRs! ('-')7 bors r=spilchen, fqazi |
This patch refactors the
ValidateNoRepeatKeysInZonefunction to a package accesible to the DSC.Informs: #117574
Release note: None