-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.1: kv: shallow copy BatchRequest on mutate in tryBumpBatchTimestamp #125576
Merged
nvanbenschoten
merged 1 commit into
release-24.1
from
blathers/backport-release-24.1-124634
Jul 8, 2024
Merged
release-24.1: kv: shallow copy BatchRequest on mutate in tryBumpBatchTimestamp #125576
nvanbenschoten
merged 1 commit into
release-24.1
from
blathers/backport-release-24.1-124634
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d743b4f
to
dfd80e9
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
arulajmani
approved these changes
Jun 12, 2024
Should we merge this @arulajmani @nvanbenschoten? I think this would fix #126081. |
IIRC @nvanbenschoten wanted to give this some bake time before we merge the backport; I'll defer to him on pressing merge. |
dfd80e9
to
fa5d7f7
Compare
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #124634 on behalf of @lyang24.
Fixes #125126.
/cc @cockroachdb/release
This avoids a data race on tryBumpBatchTimestamp, which was fallout from the new logging introduced in ba13697.
Fixes: #124553
Fixes: #126081
Release note: None
Release justification: fixes data race.