workload: fix incorrect tpcc check command #126453
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when adding support for invoking a different tpcc worload commands, the check operation was accidentally regressed by generating an invalid command (due to an incorrect argument order). To address, this patch will generate a valid check command. Fixes: cockroachdb#126443, cockroachdb#126451, cockroachdb#126447, cockroachdb#126446, cockroachdb#126443, cockroachdb#126442, cockroachdb#126440, Fixes: cockroachdb#126439, cockroachdb#126438, cockroachdb#126437, cockroachdb#126436, cockroachdb#126435 Release note: None
fqazi
requested review from
herkolategan and
DarrylWong
and removed request for
a team
|
This change is |
rafiss
approved these changes
Jul 1, 2024
|
@rafiss TFTR bors r+ |
This was referenced Jul 1, 2024
This was referenced Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when adding support for invoking a different tpcc worload commands, the check operation was accidentally regressed by generating an invalid command (due to an incorrect argument order). To address, this patch will generate a valid check command.
Fixes: #126443
Fixes: #126451
Fixes: #126447
Fixes: #126446
Fixes: #126443
Fixes: #126442
Fixes: #126440,
Fixes: #126439
Fixes: #126438
Fixes: #126437
Fixes: #126436
Fixes: #126435
Fixes: #126454
Release note: None