storage: tweak raftEntryCache allocation #13487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using cacheEntryKey and raftpb.Entry as values to OrderedCache implied an allocation for storing the values in interfaces. There was an additional allocation for the cache.Entry. These 3 allocations have been reduced to 1 using the same approach as TimestampCache: an unnamed struct composed of the key, value and cache.Entry.
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cacheEntryKey and raftpb.Entry as values to OrderedCache implied
an allocation for storing the values in interfaces. There was an
additional allocation for the cache.Entry. These 3 allocations have been
reduced to 1 using the same approach as TimestampCache: an unnamed
struct composed of the key, value and cache.Entry.
This change is
Jira issue: CRDB-14771
Jira issue: CRDB-14772