Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/parser: Permit placeholders for OID values #14255

Merged
merged 1 commit into from Mar 20, 2017
Merged

sql/parser: Permit placeholders for OID values #14255

merged 1 commit into from Mar 20, 2017

Commits on Mar 19, 2017

  1. sql/parser: Permit placeholders for OID values 

    Part of cockroachdb#14245.

Previously the `tOID` type claimed that it was ambiguous through its
`IsAmbiguous` method. This meant that a `placeholderTypeAmbiguityError`
would be thrown when issuing queries like `SELECT 1::oid = $1`. This was
incorrect, as an OID type is fully defined.

This change fixes this, and also improves the `tOid` type slightly. It
gets rid of its redundant `typeName` field. Additionally, it improves
the type's `Equivalent` and `FamilyEqual` methods, which would have
given us issues if one of the "reg oid" variants (`typeRegClass`,
`typeRegProc`, etc.) ever entered our type system.
    @nvanbenschoten
    nvanbenschoten committed Mar 19, 2017
    Configuration menu
    Copy the full SHA
    9208b50 View commit details
    Browse the repository at this point in the history