migrations: Don't crash for an old lease if we're already done #15560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@asubiotto found a flake where an ExtendLease call would return with an "unexpected value: <nil>" error and then the server would crash because the lease was too close to expiring. That error implies that the lease got released before ExtendLease was able to execute, which means that checking the `done` channel before exiting would have safely prevented the crash. Fixes cockroachdb#13237 (assuming this was the only problem with it)
|
This change is |
asubiotto
approved these changes
May 1, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@asubiotto found a flake where an ExtendLease call would return with an
"unexpected value: " error and then the server would crash because
the lease was too close to expiring. That error implies that the lease
got released before ExtendLease was able to execute, which means that
checking the
donechannel before exiting would have safely preventedthe crash.
Fixes #13237 (assuming this was the only problem with it)