rpc: Enable snappy compression by default #16432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
petermattis
approved these changes
Jun 9, 2017
| @@ -82,7 +82,7 @@ var SourceAddr = func() net.Addr { | |||
| return nil | |||
| }() | |||
|
|
|||
| var enableRPCCompression = envutil.EnvOrDefaultBool("COCKROACH_ENABLE_RPC_COMPRESSION", false) | |||
| var enableRPCCompression = envutil.EnvOrDefaultBool("COCKROACH_ENABLE_RPC_COMPRESSION", true) | |||
There was a problem hiding this comment.
I wonder if this should be changed to a cluster setting while you're mucking with this code.
There was a problem hiding this comment.
Perhaps. I'm a bit on the fence. It currently only takes effect at startup, so we'd have to rework things a bit, and even we'd only be able to make it take effect on new outgoing connections. Modifying the created servers seems like too much change.
There was a problem hiding this comment.
Ah, I was imagining a change to the setting would affect new connections. I forgot that we would want to enable it on responses from the server as well. Yeah, let's leave this as an env var.
This will be safe during rolling upgrades because the snappy decompressor was included in v1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be safe during rolling upgrades because the snappy
decompressor was included in v1.0.
#14721