Make certs valid starting yesterday #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,8 @@ import ( | |||
| // Most fields and settings are hard-coded. TODO(marc): allow customization. | |||
|
|
|||
| const ( | |||
| // Make certs valid a day before to handle clock issues (specifically boot2docker). | |||
There was a problem hiding this comment.
please link to the specific issue boot2docker/boot2docker#69
mberhault
force-pushed
the
marc/earlier_cert_start
branch
from
2a405cb
to
3e7cbef
Compare
This lets us continue in the face of clock skew, specifically on boot2docker: boot2docker/boot2docker#69
mberhault
force-pushed
the
marc/earlier_cert_start
branch
from
c49b4ff
to
5078d07
Compare
mberhault
added a commit
that referenced
this pull request
Jul 8, 2015
Make certs valid starting yesterday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.