engineccl: only emit tombstones in incremental export #16690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Wanna put "Closes #16652" in the commit message? Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. pkg/ccl/storageccl/engineccl/mvcc.go, line 165 at r1 (raw file):
This wants a comment. Comments from Reviewable |
While the import correctly handles them either way, they are just dead weight in non-incrmental export. eliding them should make backups smaller and faster. Semantics for row counts on incremental backups are now number of rows changed, which makes sense. Fixes cockroachdb#16652.
|
Done. Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. pkg/ccl/storageccl/engineccl/mvcc.go, line 165 at r1 (raw file): Previously, danhhz (Daniel Harrison) wrote…
Done. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while the import correctly handles them either way, they are just dead weight in non-incrmental export.
eliding them should make backups smaller and faster.
Semantics for row counts on incremental backups are now number of rows changed, which makes sense.