sql: return correct pgerror code for CHECK errors #17630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
requested changes
Aug 15, 2017
There was a problem hiding this comment.
Actually, while this looks perfectly sound, it would be best if you could augment one of the existing tests to ensure that the error code is present. Look in pkg/sql/logictest/testdata/logic_test/check_constraints for the existing logic tests for check constraints. You can augment a logic test with an expected pg error code by adding pgcode XXXX after the statement error - see the fk logic tests for some examples.
|
Thank you for your feedback. There were lots of tests with the CHECK constraint statement error and I think I changed most (if not all) of them. Please let me know if there is anything else I should amend. |
jordanlewis
approved these changes
Aug 16, 2017
|
Thanks for the contribution @xudongzheng! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as #16836 except for CHECK constraints.