Rework QualifiedName. #1903
Rework QualifiedName. #1903
Conversation
| if len(n) > 1 { | ||
| return n[0] | ||
| func (n *QualifiedName) Database() string { | ||
| if len(n.Indirect) > 0 { |
There was a problem hiding this comment.
can this just always return n.Base.String()?
There was a problem hiding this comment.
No. While that would work with the current tests, I think it is only due to the way we always normalize the qualified name before using the Database() method. This logic here is that an expression like foo (with no indirection expression), foo represents a table or column name and not the database name. I'll add a comment to explain this.
petermattis
force-pushed
the
pmattis/sql-indirect
branch
from
4e37906
to
2e9d701
Compare
| } | ||
| return "" | ||
| } | ||
|
|
||
| // Table returns the table portion of the name. | ||
| func (n QualifiedName) Table() string { | ||
| return n[len(n)-1] | ||
| func (n *QualifiedName) Table() string { |
There was a problem hiding this comment.
this function's correctness still depends on QualifiedName not referring to a column, is that right? maybe it deserves a comment.
There was a problem hiding this comment.
Yeah, sort of. The use of QualifiedName is context sensitive. In some contexts it refers to a table and in others to a column. I'll add a node to see the comment about Column.
|
LGTM |
petermattis
force-pushed
the
pmattis/sql-indirect
branch
from
2e9d701
to
efa9a37
Compare
| } | ||
| fmt.Fprintf(&buf, "*") | ||
| return buf.String() | ||
| return "*" |
There was a problem hiding this comment.
I thought QualifiedName took care of that now?
There was a problem hiding this comment.
I have it on my own personal TODO list to figure out if this can be further simplified. A QualifiedName can contain a *, but not as the only element or the first element which is a Name.
QualifiedName is now composed of a base name and an indirection expression. Elements in an indirection expression are either ".<name>", ".*" or "[<begin>:<end>]". Fixes #1810.
petermattis
force-pushed
the
pmattis/sql-indirect
branch
from
efa9a37
to
b7b792b
Compare
QualifiedName is now composed of a base name and an indirection
expression. Elements in an indirection expression are either ".",
".*" or "[:]".
Fixes #1810.