cherry-pick 1.1: sql: revert the default behavior of DROP DATABASE to CASCADE #19209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because that's what DROP DATABASE does in postgres, and schema migration tools expect it to work this way. However, in order to avoid unpleasant surprises by user, make DROP DATABASE *without* behavior specifier also error out when the session variable `sql_safe_updates` is set. This is the case e.g. in interactive shells by default. For example: ``` root@:26257/> drop database t; pq: rejected: DROP DATABASE on non-empty database without explicit CASCADE (sql_safe_updates = true) ```
|
This change is |
bdarnell
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #19182.
... because that's what DROP DATABASE does in postgres, and schema
migration tools expect it to work this way.
However, in order to avoid unpleasant surprises by user, make
DROP DATABASE without behavior specifier also error out
when the session variable
sql_safe_updatesis set. This isthe case e.g. in interactive shells by default. For example:
cc @cockroachdb/release