Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick-1.1: sqlccl: pass needed spans to prev backup checks #19286

Merged
merged 1 commit into from Oct 16, 2017

Commits on Oct 16, 2017

  1. sqlccl: pass needed spans to prev backup checks

    Previously we validated previous backups were well-formed and ordered.
    We did not, however, pass the spans which needed to be covered, the way we do
    when running the matching check in RESTORE, meaning that we'd accept a set of
    previous backups that didn't actually cover the spans being backed up.
    
    Re-ordering the steps in the backup plan slightly computes the matching tables
    and spans before validating the prior backups (and setting the start time), thus
    catching that case where the set of tables (and thus the spans for which we need
    complete history in order to restore) has changed.
    
    Another potential approach would be to automatically change the startTime for
    the spans for which we are missing history, effectiely de-incrementalizing those
    tables. This opens up significant additional complexity though. A simple error
    at BACKUP time should at least indicate there is an issue right away, rather
    than letting an operator believe they are making usable BACKUPs that cannot
    actually be RESTOREd.
    dt committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    577070b View commit details
    Browse the repository at this point in the history