Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #19619

Merged
merged 3 commits into from
Oct 31, 2017
Merged

Update dependencies #19619

merged 3 commits into from
Oct 31, 2017

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Oct 29, 2017

@tamird tamird self-assigned this Oct 29, 2017
@tamird tamird requested a review from a team October 29, 2017 01:07
@tamird tamird requested a review from a team as a code owner October 29, 2017 01:07
@tamird tamird requested review from a team October 29, 2017 01:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg
Copy link
Member

tbg commented Oct 29, 2017

:lgtm: but I have not audited the bumped dependencies. Let's leave this open for a few more (work) days.


Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 8 of 8 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@bdarnell
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 8 of 8 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@tamird tamird requested review from a team October 30, 2017 23:32
Notably grpc and honnef.co/go/tools.
@tamird tamird merged commit 5e1a4f5 into cockroachdb:master Oct 31, 2017
@tamird tamird deleted the update-deps branch October 31, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants