kv,grpcutil: Add an explicit preflight check for grpc connection state #21376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to what grpc does internally for fail-fast rpcs, but lets us control the error returned to work around grpc/grpc-go#1443 Fixes cockroachdb#19708 Release note (performance improvement): Reduced the occurrence of ambiguous errors when a node is down.
|
This change is |
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
We have a test that did detect the grpc breakage, but it's skipped now. This change takes the check out of grpc's hands and moves the code to distsender - if we update that test we'd end up removing a lot of the grpc calls and the test would be pretty far removed from real code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what grpc does internally for fail-fast rpcs, but
lets us control the error returned to work around grpc/grpc-go#1443
Fixes #19708
Release note (performance improvement): Reduced the occurrence of
ambiguous errors when a node is down.