cherrypick-1.1: util/log: Avoid infinite recursion out of disk errors cause an exit #21804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to write to a file when we're out of disk will trigger exitLocked, but exitLocked tries to write to its file one last time in order to help users understand why the process is exiting. This is very valuable most of the time, when the problem isn't that the machine is out of disk, but shouldn't cause a stack overflow when the machine is out of space. Fixes cockroachdb#21756 Release note (bug fix): fix a stack overflow in the code for shutting down a server when out of disk space
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to write to a file when we're out of disk will trigger
exitLocked, but exitLocked tries to write to its file one last time in
order to help users understand why the process is exiting. This is very
valuable most of the time, when the problem isn't that the machine is
out of disk, but shouldn't cause a stack overflow when the machine is
out of space.
Fixes #21756
Release note (bug fix): fix a stack overflow in the code for shutting
down a server when out of disk space