server: consider node unhealthy when liveness status is not LIVE #22502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue cockroachdb#22424 brought to light the fact that a load balancer using the /health endpoint would not consider draining nodes unhealthy, and would route requests to it. This is the first step to ensuring that load balancers do not route requests to draining nodes. Release note (bug fix): Health endpoint now returns a node as unhealthy when draining or decommissioning.
|
This change is |
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #22424 brought to light the fact that a load balancer using
the /health endpoint would not consider draining nodes unhealthy, and
would route requests to it. This is the first step to ensuring that load
balancers do not route requests to draining nodes.
Release note (bug fix): Health endpoint now returns a node as unhealthy
when draining or decommissioning.