Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick-2.0: config/storage: Expressive zone config follow-ups #23081

Merged
merged 4 commits into from Feb 26, 2018
Merged

cherrypick-2.0: config/storage: Expressive zone config follow-ups #23081

merged 4 commits into from Feb 26, 2018

Conversation

a-robinson
Copy link
Contributor

Cherry-picks:

  1. config: Address post-merge comments on expressive zone config PR #23014 to avoid restricting colons in constraints
  2. storage: Fix handling of convergeScore in selection of best candidates #23036 to fix bug where we'd sometimes pick a suboptimal store to allocate/rebalance onto
  3. *: let per-replica constraints specify less than all a zone's replicas #23057 to allow per-replica constraints that don't specify constraints for all replicas in a range
  4. config: Validate zone config fields against negative numbers #22870 to not allow negative zone config fields like NumReplicas or GC.TTLSeconds.

@cockroachdb/release

@a-robinson a-robinson requested review from petermattis and a team February 26, 2018 15:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis
Copy link
Collaborator

:lgtm:

Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

@a-robinson
storage: Fix handling of convergeScore in selection of best candidates
673c3c7 
Also add testing of rebalancing in clusters with differently sized
localities as a follow-up to cockroachdb#22412.

Release note (bug fix): Fix the occasional selection of sub-optimal
rebalance targets.
@a-robinson
*: let per-replica constraints specify less than all a zone's replicas
e3f64bc 
Release note (cli change): Per-replica constraints no longer have to add
up to the total number of replicas in a range. If don't specify all the
replicas, then the remaining replicas will be allowed on any store.
@a-robinson
config: Validate zone config fields against negative numbers
4b88d6c 
In particular, allowing a negative NumReplicas can mess with the
allocator.

Release note (bug fix): Replication zone configs will no longer
accept negative numbers as input.
@a-robinson a-robinson requested review from a team February 26, 2018 17:11
@a-robinson a-robinson merged commit 0abf5f1 into cockroachdb:release-2.0 Feb 26, 2018
@a-robinson a-robinson deleted the cherrypick_expressive branch May 18, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermattis petermattis Awaiting requested review from petermattis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a-robinson @cockroach-teamcity @petermattis