sql: the type of NULL is "unknown", not "NULL" #23142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This renames `types.Null` to `types.Unknown` and adjusts its type name accordingly. `pg_typeof()` is also modified to accept NULL arguments, so that it can return "unknown" as expected. Release note (sql change): the type determined for constant NULL expressions is renamed to "unknown" for better compatibility with PostgreSQL.
knz
force-pushed
the
20180227-null-unknown
branch
from
66511c4
to
cee2d1e
Compare
|
Review status: 0 of 36 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
TFYR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23100.
This renames
types.Nulltotypes.Unknownand adjusts its type nameaccordingly.
pg_typeof()is also modified to accept NULL arguments, so that it can return"unknown" as expected.
Release note (sql change): the type determined for constant NULL
expressions is renamed to "unknown" for better compatibility with
PostgreSQL.
cc @cockroachdb/sql